fix: har-10158 - fix comments highlighting and identify#707
Merged
harbournick merged 2 commits intodevelopfrom Jul 29, 2025
Merged
fix: har-10158 - fix comments highlighting and identify#707harbournick merged 2 commits intodevelopfrom
harbournick merged 2 commits intodevelopfrom
Conversation
falsaadehh
force-pushed
the
comments_plugin
branch
from
d24ce86 to
3dfae1c
Compare
falsaadehh
requested review from
VladaHarbour,
artem-harbour and
harbournick
and removed request for
harbournick
falsaadehh
changed the title
| let activeThreadId = commentId; | ||
| tr.setMeta(CommentsPluginKey, { type: 'setActiveComment', activeThreadId }); | ||
| tr.setMeta(CommentsPluginKey, { type: 'setActiveComment', activeThreadId: commentId, forceUpdate: true }); | ||
| dispatch(tr); |
Contributor
There was a problem hiding this comment.
In custom commands, no need to dispatch a transaction, it happens automatically.
| const { from } = findRangeById(state.doc, id) || {}; | ||
| if (from != null) { | ||
| const tr = state.tr.setSelection(TextSelection.create(state.doc, from)); | ||
| dispatch(tr); |
Contributor
There was a problem hiding this comment.
In custom commands, no need to dispatch a transaction, it happens automatically.
| element?.scrollIntoView({ behavior: 'smooth', block: 'center' }); | ||
| const element = document.querySelector(`[data-id="${newVal}"]`); | ||
| if (element) { | ||
| element?.scrollIntoView({ behavior: 'smooth', block: 'center' }); |
Contributor
There was a problem hiding this comment.
When you have if check for element, what is the meaning of element?.
| const editor = proxy.$superdoc.activeEditor; | ||
| activeComment.value = props.comment.commentId; | ||
| props.comment.setActive(proxy.$superdoc); | ||
| if (editor?.commands?.setCursorById) { |
Contributor
There was a problem hiding this comment.
I think it makes sense to check the editor instance only, not the presence of the command.
artem-harbour
requested changes
Jul 28, 2025
Contributor
artem-harbour
left a comment
artem-harbour
left a comment
There was a problem hiding this comment.
Added minor comments to fix.
@harbournick - please review comments functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.